Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ocaml 5.2 #198

Merged
merged 5 commits into from
May 26, 2024
Merged

Support ocaml 5.2 #198

merged 5 commits into from
May 26, 2024

Conversation

cristianoc
Copy link
Collaborator

Fixes #196

@cristianoc cristianoc requested a review from cknitt May 26, 2024 09:46
@cknitt
Copy link
Member

cknitt commented May 26, 2024

@cristianoc Thanks! Unfortunately I now get the errors

File "src/Noalloc.ml", line 67, characters 4-20:
Error: The constructor Tpat_var expects 3 argument(s),
       but is applied here to 2 argument(s)
File "src/Arnold.ml", line 518, characters 41-56:
Error: The constructor Tpat_var expects 3 argument(s),
       but is applied here to 2 argument(s)
File "src/DeadCommon.ml", line 339, characters 8-48:
Error: The constructor Tpat_var expects 3 argument(s),
       but is applied here to 2 argument(s)
File "src/Exception.ml", line 481, characters 6-40:
Error: The constructor Tpat_var expects 3 argument(s),
       but is applied here to 2 argument(s)

@cristianoc cristianoc changed the title Support ocaml 5.02 Support ocaml 5.2 May 26, 2024
@cristianoc
Copy link
Collaborator Author

@cknitt check again now

@cknitt
Copy link
Member

cknitt commented May 26, 2024

Thanks!
And sorry, we pushed fixes more or less simultaneously.
5.2 CI actually does work once the .opam file is updated.

@cristianoc cristianoc merged commit 5237ff5 into master May 26, 2024
10 checks passed
@cknitt cknitt deleted the ocaml_502 branch May 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCaml 5.2 support
2 participants