fix: expose max thinking level for reasoning models - #9
Open
damngamerz wants to merge 1 commit into
Open
Conversation
Advertise the extended `max` thinking level in pi for every reasoning-capable Requesty model via thinkingLevelMap, and persist it so /requesty-models-sync keeps it. `max` is a global Requesty effort value normalized per backend (OpenAI -> high, Anthropic/Gemini -> token budget), so it is safe across all models. Fixes requestyai#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the
maxthinking level for Requesty models in pi.Right now, pi-requesty registers discovered models with
reasoning: truebut nothinkingLevelMap, so pi only showsmin / low / med / high— nevermax— even for models that support it.Fix
Map each reasoning-capable model with
thinkingLevelMap: { max: "max" }(seediscoverModels), and persistthinkingLevelMapinupdateModelsJsonso/requesty-models-synckeeps it.Why this is safe for every reasoning model
Requesty's
/modelsresponse carries no machine-readable level field (onlysupports_reasoning). However,maxis a global Requesty-reasoning-effort value that Requesty normalizes per backend (see https://docs.requesty.ai/features/reasoning):"high"It is never rejected for any model type (only
xhighis model-specific). pi sends the mapped value literally asreasoning_effort, so Requesty performs the normalization.Changes
requesty.js: inlinethinkingLevelMap: reasoning ? { max: "max" } : undefinedin the discovery mapping; persist it inupdateModelsJson.Fixes #8