using reasoning_content instead of reasoning - #37
Merged
Conversation
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 18fd408..92b2cda
| Severity | Location | Issue | Delete |
|---|---|---|---|
| src/types.ts:62 | Incomplete field rename breaks streaming |
✅ Files analyzed, no issues (3)
• src/messages/handle-assistant-message.test.ts
• src/messages/handle-assistant-message.ts
• src/requesty-chat-language-model.ts
requesty-JohnCosta27
force-pushed
the
fix/reasoning-content
branch
2 times, most recently
from
March 12, 2026 15:23
5fcb876 to
2fc5763
Compare
requesty-JohnCosta27
force-pushed
the
fix/reasoning-content
branch
from
March 12, 2026 15:24
2fc5763 to
e6e5ef7
Compare
requesty-ditti
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High-level PR Summary
This PR renames the
reasoningfield toreasoning_contentthroughout the codebase to maintain consistency with API naming conventions. The change affects the type definition, message handling logic, response parsing, and corresponding test cases.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
src/types.tssrc/messages/handle-assistant-message.tssrc/requesty-chat-language-model.tssrc/messages/handle-assistant-message.test.ts