Skip to content

using reasoning_content instead of reasoning - #37

Merged
requesty-JohnCosta27 merged 1 commit into
mainfrom
fix/reasoning-content
Mar 13, 2026
Merged

using reasoning_content instead of reasoning#37
requesty-JohnCosta27 merged 1 commit into
mainfrom
fix/reasoning-content

Conversation

@requesty-JohnCosta27

@requesty-JohnCosta27 requesty-JohnCosta27 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

High-level PR Summary

This PR renames the reasoning field to reasoning_content throughout the codebase to maintain consistency with API naming conventions. The change affects the type definition, message handling logic, response parsing, and corresponding test cases.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 src/types.ts
2 src/messages/handle-assistant-message.ts
3 src/requesty-chat-language-model.ts
4 src/messages/handle-assistant-message.test.ts

Need help? Join our Discord

@recurseml recurseml Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 18fd408..92b2cda

  Severity     Location     Issue     Delete  
High src/types.ts:62 Incomplete field rename breaks streaming
✅ Files analyzed, no issues (3)

src/messages/handle-assistant-message.test.ts
src/messages/handle-assistant-message.ts
src/requesty-chat-language-model.ts

Comment thread src/types.ts
@requesty-JohnCosta27
requesty-JohnCosta27 force-pushed the fix/reasoning-content branch 2 times, most recently from 5fcb876 to 2fc5763 Compare March 12, 2026 15:23
@requesty-JohnCosta27
requesty-JohnCosta27 merged commit b418fe3 into main Mar 13, 2026
4 checks passed
@requesty-JohnCosta27
requesty-JohnCosta27 deleted the fix/reasoning-content branch March 16, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants