-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission for issue #46 #153
base: master
Are you sure you want to change the base?
Conversation
@reproducibility-org complete |
Hi, please reformat the PR so that the folder is |
@reproducibility-org not sure if this fix matches the requirement, please comment if something is missing. |
@maomran |
@reproducibility-org thanks, I think it is changed now. |
Hi, please find below a review submitted by one of the reviewers: Score: 5 I liked the following aspects:
I understand that GA requires a different level of resources to experiment with but the reproducibility effort is limited as ablation/hyper-params results are limited and the results are over single run making it hard to comment on their variability. I think the following information would make the report even more useful:
Confidence : 3 |
Hi, please find below a review submitted by one of the reviewers: Score: 5 The reproducibility study used code provided by the authors of the original paper, and, as far as I can tell, the same hyper-parameter settings as in the original paper. In this sense, this may have less value than if they had performed an independent search for hyper-parameters, especially for the DQN approach. The reproducibility study did consider role of the number of frames and number of GPU workstations in the results. The reproducibility study did not attempt to perform an extensive ablation study on the algorithms. The reproducibility study could be improved by providing a more detailed description of the findings in its tables. For example, what are the units of the results in Table 1? What are the numbers in bold in Table 2? What are findings from Table 3? Providing a detailed discussion of specific findings, and relating them to the previous work is an important contribution of this type of paper. An interesting contribution of the reproducibility work is to provide potential extensions of the GA, which is not directly a reproducibility finding, but suggests that doing the reproducibility study can be a good source of new research ideas. The paper is reasonably well written, but some important information is missing, and writing could use some polishing for journal publication. Overall, the reproducibility goals are clearly explained, but the level of completeness of the work and the explanations of the findings are not sufficiently strong to warrant publication of this report in a journal. The authors are strongly encouraged to share their work with the community. Confidence : 4 |
Hi, please find below a review submitted by one of the reviewers: Score: 5
Overall, the report is well-written, although the experiments could be improved. |
#46