Release 5.10.0 #100
Release 5.10.0 #100
Conversation
Update dockerfile and gradle.properties
* EPMRPP-82486 || Update personal data retention policy * EPMRPP-82486 || Add schedulerLock * EPMRPP-82486 || Remove dao * EPMRPP-82486 || Fix typo --------- Co-authored-by: Andrei Piankouski <[email protected]>
…e to retention policy (#85) * EPMRPP-83085 || Implement user notification about account deletion due to retention policy * EPMRPP-83085 || Add user deletion notification * EPMRPP-83085 || Fix checkstyle * EPMRPP-83085 || Fix checkstyle --------- Co-authored-by: Andrei Piankouski <[email protected]>
…ation_job_fix NotifyUserExpiration || NotifyUserExpiration job fails when sending email
EPMRPP-85418 || Email is not sent to user when the user is deleted by the job
* Update Dockerfile
EPMRPP-84893 || Add event on User Account Deletion by retention job
EPMRPP-85345 || Update the retention job with default value
EPMRPP-84893 || Added new EventObject type
Merge master to develop
Update Dockerfile for Release build
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|96 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|96 col 41| 'if rcurly' has incorrect indentation level 40, expected level should be 34.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|97 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|97 col 49| 'else' child has incorrect indentation level 48, expected level should be 36.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|98 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|98 col 41| 'else rcurly' has incorrect indentation level 40, expected level should be 34.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|99 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|100 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|100 col 9| 'method def rcurly' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|107 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|107 col 9| 'method def modifier' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|108 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|109 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|109 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|110| Line is longer than 100 characters (found 143).
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|110 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|111 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|111 col 9| 'method def rcurly' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|113 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|113 col 9| 'method def modifier' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|114 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|114 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|115 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|116 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|117 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|118 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|119 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClientImpl.java|119 col 9| 'method def rcurly' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|48| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|48 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|49 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|50 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|51 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|52 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|53 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|53 col 9| 'method def modifier' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|55| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|55 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|56 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|57 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|58 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|59 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|60 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/analyzer/index/IndexerServiceClient.java|60 col 9| 'method def modifier' has incorrect indentation level 8, expected level should be 2.
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|27| Summary javadoc is missing.
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|39| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|42| Line is longer than 100 characters (found 104).
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|43| Line is longer than 100 characters (found 122).
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|49| Line is longer than 100 characters (found 101).
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|56| Line is longer than 100 characters (found 102).
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|63| Line is longer than 100 characters (found 103).
src/main/java/com/epam/reportportal/analyzer/AnalyzerUtils.java|70| Line is longer than 100 characters (found 103).
src/main/java/com/epam/reportportal/config/rabbit/RabbitMqConfiguration.java|37| Summary javadoc is missing.
src/main/java/com/epam/reportportal/config/rabbit/RabbitMqConfiguration.java|51 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/config/rabbit/RabbitMqConfiguration.java|59 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/config/rabbit/RabbitMqConfiguration.java|77 col 3| All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '59'.
src/main/java/com/epam/reportportal/config/rabbit/RabbitMqConfiguration.java|86 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|27| Summary javadoc is missing.
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|36 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|37| Line is longer than 100 characters (found 101).
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|44| Line is longer than 100 characters (found 108).
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|44 col 96| WhitespaceAround: '-' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
src/main/java/com/epam/reportportal/logging/ExecutionTimeAspect.java|44 col 96| WhitespaceAround: '-' is not preceded with whitespace.
src/main/java/com/epam/reportportal/jobs/notification/NotifyUserExpirationJob.java|92 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/jobs/clean/DeleteExpiredUsersJob.java|119 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/jobs/BaseJob.java|15 col 5| 'method def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/jobs/processing/SaveLogMessageJob.java|27 col 3| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/ServiceJobApplication.java|23 col 1| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/ServiceJobApplication.java|24 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/ServiceJobApplication.java|24 col 17| 'annotation array initialization' child has incorrect indentation level 16, expected level should be one of the following: 2, 4.
| @@ -52,7 +52,7 @@ void shouldUpdateAllocatedStorageForAllProjects() { | |||
| when(jdbcTemplate.queryForList(SELECT_PROJECT_IDS_QUERY, Long.class)).thenReturn(projectIds); | |||
| when(jdbcTemplate.queryForObject(eq(SELECT_FILE_SIZE_SUM_BY_PROJECT_ID_QUERY), eq(Long.class), anyLong())).thenReturn(1000L); | |||
|
|
|||
| calculateAllocatedStorageJob.calculate(); | |||
| calculateAllocatedStorageJob.execute(); | |||
There was a problem hiding this comment.
Line contains a tab character.
| @@ -52,7 +52,7 @@ | |||
| when(jdbcTemplate.queryForList(SELECT_PROJECT_IDS_QUERY, Long.class)).thenReturn(projectIds); | |||
| when(jdbcTemplate.queryForObject(eq(SELECT_FILE_SIZE_SUM_BY_PROJECT_ID_QUERY), eq(Long.class), anyLong())).thenReturn(1000L); | |||
|
|
|||
| calculateAllocatedStorageJob.calculate(); | |||
| calculateAllocatedStorageJob.execute(); | |||
There was a problem hiding this comment.
'method def' child has incorrect indentation level 16, expected level should be 4.
| @@ -15,6 +21,7 @@ | |||
| import java.util.Map; | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| import static com.epam.reportportal.analyzer.AnalyzerUtils.DOES_SUPPORT_SUGGEST; | |||
There was a problem hiding this comment.
Import statement for 'com.epam.reportportal.analyzer.AnalyzerUtils.DOES_SUPPORT_SUGGEST' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line.
| @@ -23,10 +30,14 @@ | |||
| @Service | |||
| public class IndexerServiceClientImpl implements IndexerServiceClient { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(IndexerServiceClient.class); | |||
There was a problem hiding this comment.
Line contains a tab character.
| @@ -23,10 +30,14 @@ | |||
| @Service | |||
| public class IndexerServiceClientImpl implements IndexerServiceClient { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(IndexerServiceClient.class); | |||
There was a problem hiding this comment.
'member def modifier' has incorrect indentation level 8, expected level should be 2.
| } | ||
| )) | ||
| .forEach(it -> { | ||
| if (DELETE_INDEX_SUCCESS_CODE.equals(it)) { |
There was a problem hiding this comment.
Line contains a tab character.
| } | ||
| )) | ||
| .forEach(it -> { | ||
| if (DELETE_INDEX_SUCCESS_CODE.equals(it)) { |
There was a problem hiding this comment.
'if' has incorrect indentation level 40, expected level should be 34.
| )) | ||
| .forEach(it -> { | ||
| if (DELETE_INDEX_SUCCESS_CODE.equals(it)) { | ||
| LOGGER.info("Successfully deleted index '{}'", index); |
There was a problem hiding this comment.
Line is longer than 100 characters (found 102).
| )) | ||
| .forEach(it -> { | ||
| if (DELETE_INDEX_SUCCESS_CODE.equals(it)) { | ||
| LOGGER.info("Successfully deleted index '{}'", index); |
There was a problem hiding this comment.
Line contains a tab character.
| )) | ||
| .forEach(it -> { | ||
| if (DELETE_INDEX_SUCCESS_CODE.equals(it)) { | ||
| LOGGER.info("Successfully deleted index '{}'", index); |
There was a problem hiding this comment.
'if' child has incorrect indentation level 48, expected level should be 36.
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.