Fix empty parameter Dict conversion

reportportal · Oct 16, 2024 · 013dad4 · 013dad4
1 parent f963b72
commit 013dad4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 # Changelog
 
 ## [Unreleased]
+### Fixed
+- Empty parameter Dict conversion, by @HardNorth
 
 ## [5.5.8]
 ### Removed

diff --git a/reportportal_client/core/rp_requests.py b/reportportal_client/core/rp_requests.py
@@ -295,7 +295,7 @@ def _create_request(**kwargs) -> dict:
             attributes = dict_to_payload(kwargs['attributes'])
         request['attributes'] = attributes
         parameters = kwargs.get('parameters')
-        if parameters and isinstance(parameters, dict):
+        if parameters is not None and isinstance(parameters, dict):
             parameters = dict_to_payload(kwargs['parameters'])
         request['parameters'] = parameters
         return request

diff --git a/reportportal_client/helpers.py b/reportportal_client/helpers.py
@@ -130,7 +130,7 @@ def dict_to_payload(dictionary: Optional[dict]) -> Optional[List[dict]]:
     :param dictionary:  Dictionary containing tags/attributes
     :return list:       List of tags/attributes in the required format
     """
-    if not dictionary:
+    if dictionary is None:
         return dictionary
     my_dictionary = dict(dictionary)