New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status property name. Add image attachment to logs #55

Open

pedromaresteves wants to merge 2 commits into reportportal:develop from pedromaresteves:develop

pedromaresteves commented Nov 9, 2024

No description provided.

pmarques and others added 2 commits

November 8, 2024 13:38


          Fix status property name. Add attachment to stacktrace assertions

6dc9a04


          Merge pull request #1 from pedromaresteves/fix-property-names

78b954c

Fix status property name. Add attachment to stacktrace assertions

pedromaresteves requested a review from AmsterGet as a code owner

November 9, 2024 17:43

Author

pedromaresteves commented Nov 12, 2024

This PR is created to fix 2 issues with report portal agent for nightwatch.

The status property is not accepted by report portal API. Currently it's sending pass or fail but passed or failed should be sent. Line 159 addresses this.
Even though screenshots are saved when assertion fails, we are not sending those attachements to report portal, the rest of the changes address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet