Skip to content

[python] don't attempt systemdep install if no deps #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[python] don't attempt systemdep install if no deps #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/backends/python/python.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,8 @@ func commonInstallDotReplitNixDeps(ctx context.Context, pkgs []api.PkgName, spec
}
}
}

originalLen := len(allPkgs)

for _, pkg := range pkgs {
deps := nix.PythonNixDeps(string(pkg))
Expand All @@ -350,11 +352,17 @@ func commonInstallDotReplitNixDeps(ctx context.Context, pkgs []api.PkgName, spec
}
}

if len(allPkgs) == originalLen {
// No new packages were added, so we can skip writing to .replit
return
}

keys := []string{}
for key := range allPkgs {
keys = append(keys, key)
}
slices.Sort(keys)

value, err := json.Marshal(keys)
if err != nil {
util.DieSubprocess("failed to marshal JSON: %s", err)
Expand Down
Loading