Skip to content

Show message if no report events are returned #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

Show message if no report events are returned #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cli/cmd/network_report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ func (r *runners) getNetworkReportEvents() error {
if err := print.NetworkEvents(w, report.Events); err != nil {
return errors.Wrap(err, "print initial network events")
}
} else {
// Print empty report
print.NetworkReport(w, report)
}

// Track the last seen event time
Expand Down
16 changes: 10 additions & 6 deletions cli/print/network_reports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ import (

// NetworkReport prints network report in JSON format
func NetworkReport(w *tabwriter.Writer, report *types.NetworkReport) error {
reportBytes, err := json.MarshalIndent(report, "", " ")
if err != nil {
return fmt.Errorf("failed to marshal report to json: %v", err)
}
if _, err := fmt.Fprintln(w, string(reportBytes)); err != nil {
return err
if report != nil && len(report.Events) == 0 {
fmt.Fprintln(w, "You don't have any events, ensure you've enabled reporting with 'replicated network update <id> --collect-report'")
} else {
reportBytes, err := json.MarshalIndent(report, "", " ")
if err != nil {
return fmt.Errorf("failed to marshal report to json: %v", err)
}
if _, err := fmt.Fprintln(w, string(reportBytes)); err != nil {
return err
}
}
return w.Flush()
}
Expand Down