feat(create-release): add polling for status of airgap build enabled release #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdewinne
reviewed
Mar 19, 2025
| @@ -11,6 +11,12 @@ export async function actionCreateRelease() { | |||
| const releaseVersion = core.getInput('version') | |||
| const releaseNotes = core.getInput('release-notes') | |||
| const apiEndpoint = core.getInput("replicated-api-endpoint") || process.env.REPLICATED_API_ENDPOINT; | |||
| const parsedTimeout = parseInt(core.getInput('timeout-minutes') || '20'); | |||
There was a problem hiding this comment.
This should also be added to action.yml
There was a problem hiding this comment.
thank you! I have updated action.yml and README.md
src/create-release/index.ts
Outdated
|
|
||
| if (resolvedChannel.buildAirgapAutomatically) { | ||
| try { | ||
| const status = await pollForAirgapReleaseStatus(apiClient, appSlug, resolvedChannel.id, +release.sequence, "built", timeoutMinutes); |
There was a problem hiding this comment.
This should be configurable by the end-user defining if they want to wait for the Air Gap result or not. Default should be false.
There was a problem hiding this comment.
Good idea. I have added wait-for-airgap-build
jdewinne
previously approved these changes
Mar 20, 2025
|
Here is the demo which shows the create-release worked as we expected. |
jdewinne
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For create-release workflow
timeout-minutes, default is 20 minutes.sc-120959
demo