Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade install fails after partial install #3469

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emosbaugh
Copy link
Member

What this PR does / why we need it:

After my initial install failed when installing rook I tried to re-run the installer. In between running the installer a second time a new k8s version was released. When i ran a second time my installer tried to upgrade k8s and failed with the following error since the kurl-config had not yet been written.

Drain local node and apply upgrade? (Y/n) y
...
Waiting for kubernetes api health to report ok
Error from server (NotFound): configmaps "kurl-config" not found
Error from server (NotFound): configmaps "kurl-config" not found
...
Error from server (NotFound): configmaps "kurl-config" not found
Error from server (NotFound): configmaps "kurl-config" not found
Error from server (NotFound): configmaps "kurl-config" not found
Kubernetes API failed to report healthy

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an edge case that causes Kubernetes upgrades to fail after an initial installation of kURL is attempted without running to completion.

Does this PR require documentation?

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Sep 16, 2022
@emosbaugh emosbaugh requested a review from a team as a code owner September 16, 2022 21:21
@emosbaugh emosbaugh marked this pull request as draft September 16, 2022 21:30
@emosbaugh
Copy link
Member Author

I still need to test this scenario b3d4339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant