Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't report preflights bypassed if they weren't #2008

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

ajp-io
Copy link
Member

@ajp-io ajp-io commented Mar 22, 2025

What this PR does / why we need it:

We're sending PreflightsBypassed even when the user doesn't bypass them.

I ran an install where preflights failed:

core@alex-ec-selinux:~$ sudo ./gitea-mastodon install -l license.yaml
? Set the Admin Console password (minimum 6 characters): ******
? Confirm the Admin Console password: *****
Passwords don't match. Please try again.
? Set the Admin Console password (minimum 6 characters): ******
? Confirm the Admin Console password: ******
✔  Host files materialized!
✗  1 host preflight failed

 •  SELinux must be disabled or run in permissive mode. To run SELinux in permissive mode, edit /etc/selinux/config, change the line
    'SELINUX=enforcing' to 'SELINUX=permissive', save the file, and reboot. You can run getenforce to verify the change."

Please address this issue and try again.

But the reporting looked like this:
CleanShot 2025-03-21 at 20 36 11

Which issue(s) this PR fixes:

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where preflight failures were incorrectly reported as bypassed by updating the reported flag to false.

  • Change the bypass flag from true to false in preflight failure reporting.
  • Ensures that the output accurately reflects the preflight state.

@ajp-io ajp-io enabled auto-merge (squash) March 22, 2025 01:22
Copy link

github-actions bot commented Mar 22, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-c3d956a" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-c3d956a?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@ajp-io ajp-io force-pushed the fix-bad-bypass-error branch from 2311857 to c3d956a Compare March 25, 2025 20:23
@ajp-io ajp-io merged commit 1898ea7 into main Mar 26, 2025
66 checks passed
@ajp-io ajp-io deleted the fix-bad-bypass-error branch March 26, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants