-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker profiles (#1915) #1974
Open
hedge-sparrow
wants to merge
45
commits into
main
Choose a base branch
from
ash/worker-profiles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
worker profiles (#1915) #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* always enable last defined worker profile * handle errors * unmarshal to clusterconfig * rename var * extract k0s patch from unsupportedOverrides * oops * try using patch function * debug * pass overrides through to install flags * simplify worker profile determination code * just read config from disk * choose worker profile based on node role * fix crds * log profiles * f * add worker profiles to spec * workerprofiles in config * generate * split override functions * include worker profiles in cfg on join * move to unsupported overrides * always apply first defined worker profile if any are set * regenerate static * manifests --------- Co-authored-by: hedge-sparrow <[email protected]>
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
98038fb
to
f2f88bf
Compare
laverya
reviewed
Mar 20, 2025
laverya
reviewed
Mar 20, 2025
laverya
reviewed
Mar 24, 2025
laverya
reviewed
Mar 24, 2025
laverya
reviewed
Mar 24, 2025
laverya
reviewed
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current state of this PR is that worker profiles can now be defined in unsupported overrides, and the first defined worker profile is always applied on install.
TODO:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?