-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 build fail Failed to Load Docker Image Metadata #36
base: main
Are you sure you want to change the base?
Conversation
@@ -25,6 +25,8 @@ runs: | |||
steps: | |||
- name: Set up Docker buildx | |||
uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb # v3.3.0 | |||
with: | |||
use: 'false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EduarteXD I see this:
.. but I don't know enough about how Docker or buildx works to know what "Switch to this builder instance" means or what effect it might have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In buildx, the --use
parameter is used to specify an existing builder.
In the setup-buildx-action script, passing use: true
will make each build step use a new builder instance, each builder has its own context, cache, and storage space.
Therefore, the artifacts (such as intermediate layer cache, final images, etc.) between different builders are isolated by default and cannot directly access each other’s artifacts.
In each step of the cog's build, it is necessary to use --load
to directly load the built image into the Docker engine, which can take a considerable amount of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Thanks for explaining in detail. I can set up a test workflow that combines this change plus replicate/cog#1656 and see how it goes. If everything is smooth I'll merge and ship these changes.
Hey @EduarteXD I finally got around to taking this for a spin. Using this code which points at your commit:
I got this error in my Actions run: Any idea what that might be about? Were you successfully able to configure |
https://github.com/aicapcut/cog-test/actions/runs/9560733957/job/26353447883 @zeke I think this error is related to the "Free disk space" step. When I do not run this step, the action can be completed successfully. |
Please see replicate/cog#1656