Adjust Trainings#async_create signature
#409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to better align with `Trainings.create` and the way that the arguments are being used. Closes #408
erbridge
reviewed
Mar 21, 2025
| version: Union[str, Version], | ||
| input: Dict[str, Any], | ||
| model: Optional[Union[str, Tuple[str, str], "Model"]] = None, | ||
| version: Optional[Union[str, Version]] = None, |
There was a problem hiding this comment.
I don't think version is optional, is it? It looks like we'll raise a ValueError if you don't pass it in every case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to better align with
Trainings#createand the way that the arguments are being used.Closes #408