Skip to content

Update blob creation to handle Buffer inputs correctly in createFile #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update blob creation to handle Buffer inputs correctly in createFile #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ async function createFile(file, metadata = {}) {
blob = file;
} else if (Buffer.isBuffer(file)) {
filename = `buffer_${Date.now()}`;
blob = new Blob(file, { type: "application/octet-stream" });
const bytes = new Uint8Array(file);
blob = new Blob([bytes], {
type: "application/octet-stream",
name: filename,
});
} else {
throw new Error("Invalid file argument, must be a Blob, File or Buffer");
}
Expand Down