Make test prediction at end of setup #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehoover
force-pushed
the
joe/make-test-prediction-at-end-of-setup
branch
from
2932375 to
ddae533
Compare
In general, it is possible for Predict to be broken, even if setup completes. While it would be preferable to never push a model with a broken Predict, it's still useful to mitigate this risk by failing models with broken Predict during setup. This commit makes a short test prediction at the end of setup. If the prediction fails, the model is broken and will fail setup. It also fixes a bug where default prompt templates were not correctly used to format prompts.
joehoover
force-pushed
the
joe/make-test-prediction-at-end-of-setup
branch
from
ddae533 to
a2f4803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, it is possible for Predict to be broken, even if setup completes. While it would be preferable to never push a model with a broken Predict, it's still useful to mitigate this risk by failing models with broken Predict during setup.
This commit makes a short test prediction at the end of setup. If the prediction fails, the model is broken and will fail setup.
It also fixes a bug where default prompt templates were not correctly used to format prompts.