Update QRCode package #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated QRCode package dependency from WalletConnect fork to the official dagronf/QRCode repository and upgraded to version 27.11.0. This change includes:
• Switched QRCode package source from https://github.com/WalletConnect/QRCode to https://github.com/dagronf/QRCode.git
• Upgraded QRCode from version 14.3.1 to 27.11.0
• Updated related dependencies (swift-qrcode-generator from 1.0.3 to 2.0.2, SwiftImageReadWrite from 1.1.6 to 1.9.2)
• Modified QRCodeView.swift to handle API changes with proper error handling using optional binding and fallback images
• Added required reset() method implementations for custom QRCode shape extensions
This update provides access to the latest QRCode features and improvements while maintaining backward compatibility through error handling.
How Has This Been Tested?
Please test the following scenarios:
• Verify QR code generation still works correctly in the ConnectWallet screen
• Test QR code rendering with various content lengths and sizes
• Ensure fallback behavior works when QR code generation fails (should show "x.mark" system icon)
• Validate that the custom Squircle2 eye shape and pupil shapes still render correctly
To reproduce:
Due Diligence
No breaking change (API changes were handled with backward compatibility)