fix(CI): fixing clippy errors on a recent Rust version #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
commented
Jan 8, 2025
| @@ -25,8 +25,6 @@ pub struct LocalConfiguration { | |||
| pub postgres_url: String, | |||
| #[serde(default = "default_postgres_max_connections")] | |||
| pub postgres_max_connections: u32, | |||
| #[serde(default = "default_redis_url")] | |||
There was a problem hiding this comment.
Never used warning fix.
geekbrother
commented
Jan 8, 2025
| @@ -53,10 +51,6 @@ pub fn default_postgres_url() -> String { | |||
| "postgres://postgres:postgres@localhost:5432/postgres".to_owned() | |||
| } | |||
|
|
|||
| pub fn default_redis_url() -> String { | |||
There was a problem hiding this comment.
Never read warning fix.
geekbrother
commented
Jan 8, 2025
| @@ -644,11 +644,10 @@ impl From<SubscriberWithProjectResult> for SubscriberWithProject { | |||
| unread_notification_count: val | |||
| .unread_notification_count | |||
| .try_into() | |||
| .map_err(|e| { | |||
There was a problem hiding this comment.
inspect_err must be used warning fix.
geekbrother
commented
Jan 8, 2025
| @@ -19,13 +19,13 @@ pub enum Addr<'a> { | |||
| Separate { read: &'a str, write: &'a str }, | |||
| } | |||
|
|
|||
| impl<'a> Default for Addr<'a> { | |||
There was a problem hiding this comment.
No need for a lifetime a warning fix.
chris13524
reviewed
Jan 8, 2025
| // This error shouldn't happen so not bothering with returning Result here | ||
| // But if it does, this is a bug and apply use defensive programming | ||
| error!("Error converting unread_notification_count from i64 to u64: {e}"); | ||
| e | ||
| error!("Error converting unread_notification_count from i64 to u64"); |
There was a problem hiding this comment.
Looks like we are no longer logging e, why not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes clippy errors and warnings on the latest Rust version that blocks the CI/CD pipeline.
How Has This Been Tested?
Not tested.
Due Diligence