Allow user to skip logging based on host as well as path #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooly
commented
Nov 21, 2024
| @@ -29,11 +29,11 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "nokogiri" | |||
| spec.add_dependency "zeitwerk", ">= 2.0.0" | |||
|
|
|||
| spec.add_development_dependency "sqlite3", "~> 1.4.0" | |||
| spec.add_development_dependency "sqlite3", ">= 2.1" | |||
There was a problem hiding this comment.
This wants to be > 2, though I didn't check which dependency it was that was dependent on this.
wooly
commented
Nov 21, 2024
| spec.add_development_dependency "pg", "~> 1.5.4" | ||
| spec.add_development_dependency "standard", "~> 1.31" | ||
| spec.add_development_dependency "rake", "~> 12.0" | ||
| spec.add_development_dependency "rspec", "~> 3.0" | ||
| spec.add_development_dependency "rspec-rails", "~> 7.1.0" | ||
| spec.add_development_dependency "rack" | ||
| spec.add_development_dependency "rack", "< 3" |
There was a problem hiding this comment.
Rack 3 has removed the ability to rewind Rack inputs, and so the tests all fail on this line when Rack 3 is used.
coorasse
approved these changes
Nov 26, 2024
|
Thanks @coorasse! Glad I could help :) |
Merged
|
Closed via #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this up to get some opinions on it.
We have a Rails app serving an API layer on
api.*, and a web app onapp.*. We're using routing constraints to determine which routes are accessible on which subdomain. At the moment, we're running into a similar issue to that in #8 (same manifestation, different cause), in that junk requests toapp.*.com/api/v1/some-pathare resulting in a 500 error.This PR allows the user to specify a host regex to determine whether a request should be logged, similar to the way the path regex functions currently. This allows us to skip these junk requests at the middleware layer to stop them from causing the stack overflows.
Probably still needs some README.md updates, but I can do these if this is going to be merged.