Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/terragrunt): Update terragrunt packageName #33810

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

mblum14
Copy link
Contributor

@mblum14 mblum14 commented Jan 23, 2025

Fix dependency.packageName evaluated by the terragrunt manager when the terraform source url contains double slashes and ssh as the protocol (e.g., git::ssh://[email protected]/hashicorp/example.git//subdir/test?ref=1.1.0 )

Changes

Changes behavior when evaluating dependencies with the terragrunt manager. Specifically, this changes the behavior with terraform sources that have double slashes in the URL path and ssh as the protocol

for example:

# terragrunt.hcl
terraform {
  source = "git::ssh://[email protected]/hashicorp/example.git//subdir/test?ref=v1.0.4"
}

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mblum14 mblum14 force-pushed the fix_terragrunt_manager branch from 2f9d3b9 to 870e10c Compare January 23, 2025 21:24
Closes renovate/renovate#33370

- Closes renovatebot#33370

Fix dependency.packageName evaluated by the terragrunt manager when the
terraform source url contains double slashes and ssh as the protocol (e.g.,
git::ssh://[email protected]/hashicorp/example.git//subdir/test?ref=1.1.0 )
@mblum14 mblum14 force-pushed the fix_terragrunt_manager branch from 8231442 to 4d8061e Compare January 23, 2025 21:29
@viceice viceice changed the title fix(terragrunt-manager): Update terragrunt packageName fix(manager/terragrunt): Update terragrunt packageName Jan 24, 2025
@rarkins rarkins added the auto:no-merge-from-main Advise contributors not to merge from main unnecessarily label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Hi there,

Please don't merge from main into your PR's branch unless you have a merge conflict or have a specific reason to do so. Doing so consumes CI systems unnecessarily, and also resets CI approvals if this is your first PR to the repo. This repo uses GitHub's Merge Queue, which will automatically test your PR against main before merging, so it's no longer necessary to always keep branches up-to-date.

Thanks,

The Renovate team

@rarkins rarkins requested a review from viceice February 3, 2025 14:57
@rarkins rarkins added this pull request to the merge queue Feb 3, 2025
Merged via the queue into renovatebot:main with commit 6f862cc Feb 3, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.158.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Feb 5, 2025
* upstream/main: (27 commits)
  chore(deps): update python:3.13 docker digest to 7be9b75 (renovatebot#34045)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.7.7 (renovatebot#34043)
  docs(gitea): fix `gitUrl` support (renovatebot#34038)
  feat(npm): Support for new option `replacementApproach` (renovatebot#34018)
  chore(deps): lock file maintenance (renovatebot#33998)
  chore(deps): update sigstore/cosign-installer action to v3.8.0 (renovatebot#34034)
  docs(managers/pip-compile): update list of source files and managers (renovatebot#34030)
  chore(deps): update linters to v8.22.0 (renovatebot#33880)
  fix(gitea): use endpoint for pr cache pagination (renovatebot#34022)
  chore(deps): update otel/opentelemetry-collector-contrib docker tag to v0.119.0 (renovatebot#34032)
  feat(gradle): add support for gradle repository content descriptors (renovatebot#33692)
  feat(manager): add elixir as a mise core tooling (renovatebot#34025)
  chore(deps): update python:3.13 docker digest to d59d263 (renovatebot#34026)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.7.6 (renovatebot#34021)
  fix(gitea): allow overriding platform version (renovatebot#34019)
  chore(deps): update dependency @types/lodash to v4.17.15 (renovatebot#34020)
  fix(manager/terragrunt): Update terragrunt packageName (renovatebot#33810)
  feat(pip-compile): support `uv pip compile` (renovatebot#33952)
  fix(deps): update dependency mkdocs-material to v9.6.2 (renovatebot#34010)
  chore(label-actions): improve logs, pr closing (renovatebot#33995)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:no-merge-from-main Advise contributors not to merge from main unnecessarily
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terragrunt: Failed to properly parse git/ssh dependency with sub directory
4 participants