Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/github-runners): Add ubuntu-22.04-arm and ubuntu-24.04-arm support #33680

Conversation

edgarrmondragon
Copy link

@edgarrmondragon edgarrmondragon commented Jan 17, 2025

Changes

Adds support for public preview GitHub Runners ubuntu-22.04-arm and ubuntu-24.04-arm.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@edgarrmondragon edgarrmondragon changed the title Add ubuntu-22.04-arm and ubuntu-24.04-arm support in GitHub Runners feat: Add ubuntu-22.04-arm and ubuntu-24.04-arm support in GitHub Runners Jan 17, 2025
@edgarrmondragon edgarrmondragon force-pushed the github-runner-linux-arm64 branch from acab855 to 4d1fa5c Compare January 17, 2025 23:27
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 17, 2025 23:28
@@ -46,6 +50,13 @@ export class GithubRunnersDatasource extends Datasource {
],
};

private static readonly supportsLatest: Record<string, boolean> = {
ubuntu: true,
ubuntu_arm64: false,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins rarkins changed the title feat: Add ubuntu-22.04-arm and ubuntu-24.04-arm support in GitHub Runners feat(datasource/github-runners): Add ubuntu-22.04-arm and ubuntu-24.04-arm support Jan 17, 2025
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to simply add them as additional versions to the datasource and use the suffix as version compatibility.

@rarkins @secustor wdyt?

@edgarrmondragon
Copy link
Author

I would prefer to simply add them as additional versions to the datasource and use the suffix as version compatibility.

@rarkins @secustor wdyt?

Thanks for the feedback @viceice! I'm getting my feet wet in the codebase, I see the github-runners datasource uses docker as the default versioning scheme. Does that mean that ubuntu-24.04 and ubuntu-24.04-arm will be deemed incompatible (and thus never updated from one to the other) similar to Docker images python:3.13 and python:3.13-slim?

@viceice
Copy link
Member

viceice commented Jan 19, 2025

yes

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.132.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants