Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of Gitlab's sections for CODEOWNERS (#29202) #32061

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaximeMorille
Copy link

Changes

Add support for Gitlab's sections in CODEOWNERS files, notably their default approver feature.

Context

Closes #29202

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required (not so sure about that, but I didn't find a part worthy of update)

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MaximeMorille MaximeMorille changed the title Add support of Gitlab's sections for CODEOWNERS (#29202) feat: add support of Gitlab's sections for CODEOWNERS (#29202) Oct 21, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does GitLab's approach conflict with other platforms, particularly GitHub? This change is in lib/workers which means it will apply to all platforms

@MaximeMorille
Copy link
Author

Good point, it does conflict with Gitea format.

I will take a look at the platform folder to see if there is a way to implement this only for Gitlab.

@MaximeMorille MaximeMorille marked this pull request as draft October 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab CODEOWNERS: support for default section owner
2 participants