JSON-safe != HTML-safe #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.stringify enables you to safely include an untrusted string in JavaScript, it's true. But when bootstrapping model data, the bootstrap JavaScript is wrapped in an HTML container (i.e. inline script tag). That means that a string like "
</script>", which is a valid JavaScript string, will cause the HTML container to think that the JavaScript section has ended, which is an exploitable vulnerability. For an example, visit http://localhost:3030/users/CGamesPlay in the first Rendr example.I believe this issue resides in rendr-handlebars because handlebars is typically used to make HTML documents, and so the json helper should assume that the output from the function (the SafeString, as it's called) will be included in an HTML container.
It should be possible to fix this up by replacing all
'/'with'\\/', but that may have performance implications if the bootstrapped data isn't gzipped... seems unlikely though. Thoughts?