Skip to content

Conversation

@jkwiecien
Copy link

This fixes #28 by:

  • updating gradle to the recent one
  • updating support lib to the recent one

In the process also updated build tools, compile and target sdk, and added some shared variables in global build.gradle

… keywords with a new ones, updates support lib and target and compile sdk
@@ -1,14 +1,15 @@
apply plugin: 'com.android.library'
apply plugin: 'com.github.dcendents.android-maven'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that required ?

@renaudcerrato
Copy link
Owner

renaudcerrato commented Mar 21, 2018

Thanks @jkwiecien, but there's quite a few cleanup required before merging that PR :

  • Not sure why you need the plugin com.github.dcendents.android-maven, this is not necessary IMO
  • Your commit includes a lot of white space change in several places, including java files. This is not relevant to the PR
  • You added a gradle/wrapper folder into the /sample, which is not needed.

@jkwiecien
Copy link
Author

How would I solve the whitespaces problem? You probably used some custom code style formatter while I'm using the default AS one. Is your custom formatter part of the repo?

@renaudcerrato
Copy link
Owner

@jkwiecien : just don't git add those java files ? It looks like there's no source file update required, right?

@jkwiecien
Copy link
Author

There is for sure at least one source file updated on purpose

@jkwiecien
Copy link
Author

I just checked. There were files updated for a reason. Just the change got lost in a crowd of white spaces, because as said before, you were using some custom format. You'll have to add it to the repo if you want me to fix it.

@renaudcerrato
Copy link
Owner

Mmmm... I'm not using any custom formater for the exact reason we're experiencing now : that mess with PR when contributing. Let's forget about the whitespaces, but what's about the unwanted plugin and gradle folder?

@jkwiecien
Copy link
Author

Deleted the unwanted gradle files from sample module. You should double check your code style formatter because I' pretty sure it's a custom one.

}

static private Drawable unwrap(Drawable icon) {
if(icon instanceof android.support.v7.graphics.drawable.DrawableWrapper)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part that was crashing, I'm not sure why the conditions were here, maybe you got some valid reasons, however, some of these classes/methods are not accessible anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DrawableWrapper crashes

2 participants