fix(ui): sync bubbles list filter key with custom binding#152
Merged
renato0307 merged 1 commit intomainfrom Feb 10, 2026
Merged
fix(ui): sync bubbles list filter key with custom binding#152renato0307 merged 1 commit intomainfrom
renato0307 merged 1 commit intomainfrom
Conversation
The bubbles list.Model has its own internal KeyMap.Filter that defaults to "/". When the filter shortcut was swapped to ctrl+f, only rocha's custom KeyMap was updated but the bubbles list's internal filter trigger was never synced, making ctrl+f non-functional.
renato0307
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ctrl+f filter shortcut not working after the keyboard shortcut swap in #151.
Changes
Context
The bubbles list.Model has its own internal KeyMap.Filter that defaults to "/".
When #151 swapped the filter shortcut from "/" to "ctrl+f", only rocha's custom
KeyMap was updated but the list's internal filter trigger was never synced.