Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic trim gap #16

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

fireblade2534
Copy link
Contributor

changes the system for combining chunks so it ensures there is a consistent gap between chunk speaking

@fireblade2534
Copy link
Contributor Author

fireblade2534 commented Jan 10, 2025

@remsky I think i'm done implementing the dynamic trim code

@fireblade2534
Copy link
Contributor Author

fireblade2534 commented Jan 10, 2025

btw about the conflict in audio.py I think what I have works the best as without it the end of the whole concatenated audio gets normalized which means that the dynamic gap system doesn't work cause it just gets the full audio and not each chunk.

@remsky
Copy link
Owner

remsky commented Jan 10, 2025

Makes sense. I'll check it out

@remsky
Copy link
Owner

remsky commented Jan 10, 2025

@fireblade2534 Working a few conflicts through with the implementation, a few bugs on the tests. But will check it out more tomorrow, and add some CI/CD

@fireblade2534
Copy link
Contributor Author

@remsky

@remsky
Copy link
Owner

remsky commented Jan 16, 2025

Hey @fireblade2534 , sorry for the delay. Just been adjusting the structure to protect against some of the docker issues, and to make things more modular so different strategies for chunking, etc, can be swapped around more easily. Getting to this soon though

@fireblade2534
Copy link
Contributor Author

Hey @fireblade2534 , sorry for the delay. Just been adjusting the structure to protect against some of the docker issues, and to make things more modular so different strategies for chunking, etc, can be swapped around more easily. Getting to this soon though

Got it

@fireblade2534 fireblade2534 mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants