@remotion/web-renderer: Fix margins being applied twice
#5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
JonnyBurger
November 18, 2025 12:32
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where margins on SVG elements were being applied twice during rendering in the @remotion/web-renderer package. The fix sets margins to '0' before serializing the SVG, since margins are already included in positioning calculations.
Key changes:
- Added margin reset logic in
svgToImageBitmapfunction to prevent double-counting - Added a comprehensive test case with nested transforms and margins to verify the fix
- Updated test viewport height from 720 to 1080 to accommodate the new 1080x1080 test composition
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-renderer/src/compose-svg.ts | Added margin reset (marginLeft, marginRight, marginTop, marginBottom) before SVG serialization to fix double-counting issue |
| packages/web-renderer/src/test/transforms.test.tsx | Added new test case "complicated example" with nested transforms and SVG elements using margins to verify the fix |
| packages/web-renderer/vitest.config.ts | Increased viewport height from 720 to 1080 pixels across all browser configs to support the new test dimensions |
| packages/web-renderer/src/test/screenshots/*.png | Added visual regression test snapshots for the new test across different browsers (chromium, firefox, webkit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.