Skip to content

Remove missing react-router exports in tests #13392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

markdalgleish
Copy link
Member

Some of our tests have unused imports from React Router that are no longer exported, leftover from the Remix migration. Vite builds with these without any issues, but rolldown-vite is more strict. This PR fixes the tests to help ensure vite-ecosystem-ci can pass against vite-rolldown without having to suppress these errors in Rolldown.

Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: 2a2343c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 416d3e2 into dev Apr 10, 2025
15 of 19 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-test-imports branch April 10, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant