Add remark ignore path settings - #143
Closed
astrobrownmusic wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
astrobrownmusic
force-pushed
the
add-ignore-path-setting
branch
2 times, most recently
from
May 28, 2026 01:47
830d12d to
936e456
Compare
astrobrownmusic
force-pushed
the
add-ignore-path-setting
branch
from
May 28, 2026 01:49
936e456 to
18c74ca
Compare
Member
|
This looks like AI slop. I’m sorry if you’re human. |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This wires the existing language-server ignore-path support into the VS Code extension by declaring
remark.ignorePathandremark.ignorePathResolveFromin the extension configuration, documenting both settings, and covering the custom ignore-path behavior in the formatter test.unified-language-serveralready supports these settings on current main, andremark-language-serveralready documents them. This PR adds the VS Code extension side so users can configure the custom ignore path from settings.After an initial macOS CI failure, I removed the client-side default for
remark.ignorePathResolveFromso the language server keeps ownership of its existing default behavior when users have not configured an ignore path.The formatter test now calls VS Code's format-provider command directly and applies the returned edits. That verifies the language-server formatter without relying on platform-dependent UI formatter selection.
Verification:
node -e "const assert=require('node:assert/strict'); const p=require('./package.json'); const props=p.contributes.configuration.properties; assert.equal(props['remark.ignorePath'].type,'string'); assert.deepEqual(props['remark.ignorePathResolveFrom'].enum,['dir','cwd']); assert.equal(Object.hasOwn(props['remark.ignorePathResolveFrom'],'default'),false); console.log('manifest settings ok')"npm.cmd run buildgit diff --checknpm.cmd testin clean no-space worktree atC:\Users\t30br\.config\superpowers\worktrees\vscode-remark\ci-repro- 3 passingnpm.cmd testin my original Windows workspace could not produce a meaningful extension-host result because the pathD:\Downloads\AI Makes me money autonomouslywas split by the runner asd:\Downloads\AI.Closes #142