Skip to content

Add remark ignore path settings - #143

Closed
astrobrownmusic wants to merge 1 commit into
remarkjs:mainfrom
astrobrownmusic:add-ignore-path-setting
Closed

Add remark ignore path settings#143
astrobrownmusic wants to merge 1 commit into
remarkjs:mainfrom
astrobrownmusic:add-ignore-path-setting

Conversation

@astrobrownmusic

@astrobrownmusic astrobrownmusic commented May 28, 2026

Copy link
Copy Markdown

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and could not find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that is not needed)

Description of changes

This wires the existing language-server ignore-path support into the VS Code extension by declaring remark.ignorePath and remark.ignorePathResolveFrom in the extension configuration, documenting both settings, and covering the custom ignore-path behavior in the formatter test.

unified-language-server already supports these settings on current main, and remark-language-server already documents them. This PR adds the VS Code extension side so users can configure the custom ignore path from settings.

After an initial macOS CI failure, I removed the client-side default for remark.ignorePathResolveFrom so the language server keeps ownership of its existing default behavior when users have not configured an ignore path.

The formatter test now calls VS Code's format-provider command directly and applies the returned edits. That verifies the language-server formatter without relying on platform-dependent UI formatter selection.

Verification:

  • node -e "const assert=require('node:assert/strict'); const p=require('./package.json'); const props=p.contributes.configuration.properties; assert.equal(props['remark.ignorePath'].type,'string'); assert.deepEqual(props['remark.ignorePathResolveFrom'].enum,['dir','cwd']); assert.equal(Object.hasOwn(props['remark.ignorePathResolveFrom'],'default'),false); console.log('manifest settings ok')"
  • npm.cmd run build
  • git diff --check
  • npm.cmd test in clean no-space worktree at C:\Users\t30br\.config\superpowers\worktrees\vscode-remark\ci-repro - 3 passing

npm.cmd test in my original Windows workspace could not produce a meaningful extension-host result because the path D:\Downloads\AI Makes me money autonomously was split by the runner as d:\Downloads\AI.

Closes #142

@github-actions github-actions Bot added the 👋 phase/new Post is being triaged automatically label May 28, 2026
@github-actions

This comment has been minimized.

@astrobrownmusic
astrobrownmusic force-pushed the add-ignore-path-setting branch 2 times, most recently from 830d12d to 936e456 Compare May 28, 2026 01:47
@astrobrownmusic
astrobrownmusic force-pushed the add-ignore-path-setting branch from 936e456 to 18c74ca Compare May 28, 2026 01:49
@github-actions github-actions Bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 28, 2026
@remcohaszing

Copy link
Copy Markdown
Member

This looks like AI slop. I’m sorry if you’re human.

@github-actions

This comment has been minimized.

@remcohaszing remcohaszing added 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Development

Successfully merging this pull request may close these issues.

Allow specifying the location of markdownignore file

2 participants