Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regex): accepting numbers in name #45

Closed
wants to merge 3 commits into from
Closed

fix(regex): accepting numbers in name #45

wants to merge 3 commits into from

Conversation

aarnphm
Copy link

@aarnphm aarnphm commented Aug 17, 2024 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The current userGroup doesn't accept number in name, even though it is a valid user i.e: myname0. This PR aims to address that problem.

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Aug 17, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 17, 2024
@wooorm
Copy link
Member

wooorm commented Aug 19, 2024

\d matches numbers

@wooorm wooorm closed this Aug 19, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Aug 19, 2024
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Aug 19, 2024
@aarnphm aarnphm deleted the patch-1 branch August 19, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarnphm @wooorm