Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Dependabot with cd-red-bot #31

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Replace Dependabot with cd-red-bot #31

merged 2 commits into from
Aug 20, 2024

Conversation

JAVGan
Copy link
Collaborator

@JAVGan JAVGan commented Aug 20, 2024

This PR replaces the dependabot with a custom GH action which will constantly attempt to update the dependencies in a grouped way and open PRs through the cd-red-bot, similarly to what is already being used by neighbor projects such as pubtools-ami

With this we'll have the following advantages:

  1. Automatically grouped updates
  2. Dependencies being updated in the very same way we create/update the requirements-* without treating those files separately
  3. More control on future automation (e.g. we can update it later to automatically approve/merge if everything is ok)

This commit adds a new action named `pip-compile` which will daily
attempt to update the dependencies and open a new MR when necessary.

The advantage of doing this is that we can easily group the dependencies
without having to rely on complex iterations with dependabot.

This approach is the very same used in neighbor projects, such as
pubtools-ami:

https://github.com/release-engineering/pubtools-ami/blob/main/.github/workflows/pip-compile.yml

Refers to SPSTRAT-355
Let's rely in our own GH actions to do it by using our internal bot.

Refers to SPSTRAT-355
@JAVGan
Copy link
Collaborator Author

JAVGan commented Aug 20, 2024

@lslebodn @jajreidy please let me know what do you think... I believe we can do this for all repos, it will make our lives easier by having a proper pip-compile routine which generates our requirements in a streamlined way rather than relying on multiple PRs by dependabot.

@JAVGan
Copy link
Collaborator Author

JAVGan commented Aug 20, 2024

Related PR on cloudpub: release-engineering/cloudpub#33

Copy link
Collaborator

@jajreidy jajreidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. LGTM

@JAVGan JAVGan merged commit 25d3253 into main Aug 20, 2024
22 checks passed
@JAVGan JAVGan deleted the choredeps branch August 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants