Skip building multi-arch binary-less image #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVGan
force-pushed
the
binaryless_singlearch
branch
2 times, most recently
from
99aa987 to
54c7d14
Compare
JAVGan
changed the title
JAVGan
force-pushed
the
binaryless_singlearch
branch
3 times, most recently
from
96e2896 to
216e5b8
Compare
lipoja
reviewed
Feb 26, 2025
lipoja
requested changes
Feb 26, 2025
xDaile
reviewed
Feb 26, 2025
JAVGan
force-pushed
the
binaryless_singlearch
branch
from
216e5b8 to
0f5b9dd
Compare
There was a problem hiding this comment.
@JAVGan The code LGTM
While testing this change I noticed that if we build index image without binary image we see less labels for the index image.
I think its okay but I have reached out to stakeholders to confirm that..
Lets wait for the confirmation before merging this PR
lipoja
requested changes
Feb 27, 2025
JAVGan
force-pushed
the
binaryless_singlearch
branch
2 times, most recently
from
43d0dd4 to
26afe38
Compare
This commit allows IIB to process a single build for binaryless images with a generic architecture labeled as "linux-amd64" Refers to CLOUDDST-23383
JAVGan
force-pushed
the
binaryless_singlearch
branch
from
26afe38 to
e69d222
Compare
|
@lipoja PTAL again |
lipoja
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows IIB to process a single build for binaryless images with a generic architecture labeled as "linux-amd64"
Refers to CLOUDDST-23383