[Draft] Add Pydantic models to IIB #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDaile
force-pushed
the
pydantic
branch
2 times, most recently
from
7a6a734
to
7f34604
Compare
xDaile
force-pushed
the
pydantic
branch
4 times, most recently
from
d69a673
to
bbd3201
Compare
xDaile
commented
Dec 8, 2023
xDaile
force-pushed
the
pydantic
branch
6 times, most recently
from
87d221c
to
8a5a898
Compare
xDaile
commented
Dec 11, 2023
xDaile
force-pushed
the
pydantic
branch
9 times, most recently
from
33c393c
to
8218ba7
Compare
xDaile
force-pushed
the
pydantic
branch
4 times, most recently
from
819b658
to
817c252
Compare
xDaile
force-pushed
the
pydantic
branch
4 times, most recently
from
c93bc96
to
99cb767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks from the 'from_json' method were moved to Pydantic models.
Leftovers from 'from_json' methods can be seen in 'from_json_replacement' methods, which could be rewritten into one common method as seen in "from_json_replacement_even_shorter".
Some inheritance would also be possible in pydantic_models.py.