[WIP] Add jsondata#19
Open
keigohtr wants to merge 3 commits into
Open
Conversation
keigohtr
commented
Sep 30, 2019
Member
Author
keigohtr
left a comment
keigohtr
left a comment
There was a problem hiding this comment.
I have commented the major changes.
| service Health { | ||
| rpc Check(HealthCheckRequest) returns (HealthCheckResponse); | ||
|
|
||
| rpc Watch(HealthCheckRequest) returns (stream HealthCheckResponse); |
Member
Author
There was a problem hiding this comment.
This is the latest spec -> https://github.com/grpc/grpc/blob/master/doc/health-checking.md
| message RekcurdMessage { | ||
| Status status = 1; | ||
| JsonFormatString meta = 2; | ||
| google.protobuf.Value meta = 2; |
| StatusFlag status = 4; | ||
| } | ||
|
|
||
| // JsonFormatString message. |
| bytes binData = 4; | ||
| string strData = 5; | ||
| StringList strDataList = 6; | ||
| google.protobuf.Value jsonData = 6; |
Member
Author
There was a problem hiding this comment.
According to the official doc, Value represents a dynamically typed value which can be either null, a number, a string, a boolean, a recursive struct value, or a list of values.
| repeated double val = 2; | ||
| } | ||
|
|
||
| // StringList message. |
Member
Author
|
I will add util methods by referring Seldon's utils.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will add the util methods for RekcurdMessage.
What is this PR for?
Update to the latest spec of Seldon Core -> Link
This PR includes
What type of PR is it?
Update
What is the issue?
N/A
How should this be tested?
N/A