fix: commit & rollback without transaction no longer throw an excepti…

…on (#82)

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.2.3
+
+* fix: commit & rollback without transaction no longer throw an exception
+
 ## 2.2.2
 
 * fix: handle case where `ProfilerController` is not available

packages/domain-event/src/Model/TransactionAwareDomainEventStore.php

@@ -77,31 +77,41 @@ public function beginTransaction(): void
         }
     }
 
-    public function commit(): void
+    /**
+     * @return bool false if there is no transaction in progress
+     */
+    public function commit(): bool
     {
         if ($this->transactionStore === null) {
-            throw new InvalidOperationException('Cannot commit, no transaction in progress');
+            return false;
         }
 
-        try {
-            $this->transactionStore->commit();
-        } catch (InvalidOperationException) {
+        $result = $this->transactionStore->commit();
+
+        if ($result === false) {
             $transactionStore = $this->transactionStore;
             $this->transactionStore = null;
             $this->add($transactionStore->pop());
         }
+
+        return true;
     }
 
-    public function rollback(): void
+    /**
+     * @return bool false if there is no transaction in progress
+     */
+    public function rollback(): bool
     {
         if ($this->transactionStore === null) {
-            throw new InvalidOperationException('Cannot rollback, no transaction in progress');
+            return false;
         }
 
-        try {
-            $this->transactionStore->rollback();
-        } catch (InvalidOperationException) {
+        $result = $this->transactionStore->rollback();
+
+        if ($result === false) {
             $this->transactionStore = null;
         }
+
+        return true;
     }
 }