Skip to content

Commit

Permalink
chore: cleanup (#97)
Browse files Browse the repository at this point in the history
* chore: cs

* fix phpstan errors

* force psalm check at php 8.2

* add php version req in composer.json
  • Loading branch information
priyadi authored May 30, 2024
1 parent 021f882 commit 38ac31b
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 9 deletions.
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
}
],
"require": {
"php": "^8.1",
"doctrine/doctrine-bundle": "^2.11.3 || ^2.12",
"doctrine/orm": "^2.16 || ^3.0",
"doctrine/persistence": "^3.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@

/**
* Decorates entity managers manually instead of relying on DI's decoration.
*
*
* `ManagerRegistry::resetManager()` relies on the fact that entity managers are
* lazy. However, when we decorate entity managers, the original entity manager
* won't lazy anymore. This causes `resetManager()` to fail. the workaround is to
* manually decorate entity managers.
*
*
* @internal
*/
final class EntityManagerDecoratorPass implements CompilerPassInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
* accepts "Doctrine\Bundle\DoctrineBundle\Registry",
* "Rekalogika\DomainEvent\Doctrine\DomainEventAwareManagerRegistryImplementation"
* passed.
*
*
* fix in upstream: https://github.com/doctrine/DoctrineBundle/pull/1764
*
*
* @todo remove after we bump to doctrine/doctrine-bundle 2.12
*
* @internal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public function onRemoveCalled(): bool
return $this->onRemoveCalled;
}

/** @phpstan-impure */
public function onChangeCalled(): int
{
return $this->onChangeCalled;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public function onRemoveCalled(): bool
return $this->onRemoveCalled;
}

/** @phpstan-impure */
public function onChangeCalled(): int
{
return $this->onChangeCalled;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public function onRemoveCalled(): bool
return $this->onRemoveCalled;
}

/** @phpstan-impure */
public function onChangeCalled(): int
{
return $this->onChangeCalled;
Expand Down
3 changes: 1 addition & 2 deletions tests/Framework/EventListener/PostEventEventBusListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ public function onRemoveCalled(): bool
{
return $this->onRemoveCalled;
}

/** @phpstan-impure */

public function onChangeCalled(): int
{
return $this->onChangeCalled;
Expand Down

0 comments on commit 38ac31b

Please sign in to comment.