Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve references for figma aliases #224

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

c4rlosviteri
Copy link
Contributor

PR for preserving references and allowing uses aliases in Figma / Tokens Studio

@c4rlosviteri c4rlosviteri requested a review from mhewson November 18, 2024 19:43
@c4rlosviteri c4rlosviteri force-pushed the pr/preserve-references-for-figma-aliases branch from e332c17 to 32aeee0 Compare November 18, 2024 19:44
@c4rlosviteri c4rlosviteri force-pushed the pr/preserve-references-for-figma-aliases branch from 32aeee0 to d3dd6a1 Compare November 18, 2024 19:46
@@ -6810,7 +6810,7 @@
"filePath": "tokens/themes/rei-dot-com/button.json5",
"isSource": true,
"original": {
"$value": "#13352C",
"$value": "#13352c",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the lowercase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other colors are lowercase, just a small standardization thing

@sikhote sikhote assigned sikhote and c4rlosviteri and unassigned sikhote Nov 18, 2024
@sikhote sikhote self-requested a review November 18, 2024 21:20
@c4rlosviteri c4rlosviteri merged commit 5ecd4f5 into next Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants