Skip to content

Commit

Permalink
add test for stdlib-migration: arrow
Browse files Browse the repository at this point in the history
almost all outputs gain a host dependence on stdlib (including `apache-arrow-proc`,
where we insert the host section due to the assumption that an output without a
build section is relying on the global build requirements).

Note that `libarrow-all` does not gain a stdlib-dependence, as it _has_ a non-empty
build section.

```
diff --git a/tests/test_yaml/stdlib_arrow_before_meta.yaml b/tests/test_yaml/stdlib_arrow_after_meta.yaml
index 85771bad..60b4550b 100644
--- a/tests/test_yaml/stdlib_arrow_before_meta.yaml
+++ b/tests/test_yaml/stdlib_arrow_after_meta.yaml
@@ -55,6 +55,7 @@ requirements:
     - autoconf     # [linux]
     - make         # [linux]
   host:
+    - {{ stdlib("c") }}
     # for required dependencies, see
     # https://github.com/apache/arrow/blob/apache-arrow-11.0.0/cpp/cmake_modules/ThirdpartyToolchain.cmake#L46-L75
     - clangdev {{ llvm_version }}
@@ -94,6 +95,8 @@ outputs:
       number: {{ proc_build_number }}
       string: {{ build_ext }}
     requirements:
+      host:
+        - {{ stdlib("c") }}
       run_constrained:
         # avoid installation with old naming of proc package
         - arrow-cpp-proc <0.0a0
@@ -185,6 +188,7 @@ outputs:
         - {{ compiler("cxx") }}
         - {{ compiler("cuda") }}                 # [cuda_compiler_version != "None"]
       host:
+        - {{ stdlib("c") }}
         - aws-crt-cpp
         - aws-sdk-cpp
         - brotli
@@ -286,6 +290,7 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", exact=True) }}
       run:
         - {{ pin_subpackage("libarrow", exact=True) }}
@@ -330,6 +335,7 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", exact=True) }}
         - {{ pin_subpackage("libarrow-acero", exact=True) }}
         - {{ pin_subpackage("libparquet", exact=True) }}
@@ -381,6 +387,7 @@ outputs:
         - libgrpc                                # [build_platform != target_platform]
         - libprotobuf                            # [build_platform != target_platform]
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", exact=True) }}
         - libabseil
         - libgrpc
@@ -435,6 +442,7 @@ outputs:
         - libgrpc                                # [build_platform != target_platform]
         - libprotobuf                            # [build_platform != target_platform]
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", exact=True) }}
         - {{ pin_subpackage("libarrow-flight", exact=True) }}
         - libprotobuf
@@ -482,6 +490,7 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", max_pin="x") }}
         - libutf8proc
         # gandiva requires shared libllvm; needs to match version used at build time
@@ -538,6 +547,7 @@ outputs:
         - cmake
         - ninja
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", exact=True) }}
         - {{ pin_subpackage("libarrow-acero", exact=True) }}
         - {{ pin_subpackage("libarrow-dataset", exact=True) }}
@@ -588,6 +598,7 @@ outputs:
         - {{ compiler("c") }}
         - {{ compiler("cxx") }}
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow", max_pin="x") }}
         - openssl
         - thrift-cpp
@@ -647,6 +658,7 @@ outputs:
         - cmake
         - ninja
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow-all", exact=True) }}
         - clangdev {{ llvm_version }}
         - llvmdev {{ llvm_version }}
@@ -738,6 +750,7 @@ outputs:
         - cmake
         - ninja
       host:
+        - {{ stdlib("c") }}
         - {{ pin_subpackage("libarrow-all", exact=True) }}
         - {{ pin_subpackage('pyarrow', exact=True) }}
         - clangdev {{ llvm_version }}
```
  • Loading branch information
h-vetinari committed Feb 7, 2024
1 parent edb1793 commit 257fdb6
Show file tree
Hide file tree
Showing 3 changed files with 1,734 additions and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_stdlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
@pytest.mark.parametrize(
"feedstock,new_ver",
[
# blank for now
("arrow", "1.10.0"),
],
)
def test_stdlib(feedstock, new_ver, tmpdir):
Expand Down
Loading

0 comments on commit 257fdb6

Please sign in to comment.