fix: APP-913 disable 'save credit card' if Link is used#2835
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces logic to handle Stripe Link payments by disabling the 'Save my credit card' option and attempts to manage React Strict Mode behavior in the purchase form. However, the review identifies two critical issues: the use of a ref to skip cleanup in AgreePurchaseForm will prevent state resets in production environments, and the removal of the elements.update call in PaymentInfoForm creates a regression for standard credit card payments where users can no longer save their payment information.
|
@erikalogie @S4mmyb see testing instructions |
1 participant
Description
https://regennetwork.atlassian.net/browse/APP-913
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From https://deploy-preview-2835--regen-marketplace.netlify.app/project/terrasos-project-with-fiat-sell-order/buy
Choose "link" as payment method, this should disable "Save my credit card info for next time"
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...