Revert "reflex-dom-core: disable tests to fix determinism" #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should look at the actual error and fix it. There are some hard coded wait times in the tests, if they're causing the failure we can increase them somewhat. AFAICT candidates functions to adjust are `withSeleniumServer` and `withRetry`. Running the `gc` test with `cpulimit -l 1` results in: ``` ... 438664 436864 440056 SUCCEEDED [0207/130124.616315:ERROR:broker_posix.cc(40)] Recvmsg error: Connection reset by peer (104) ``` which may also be considered a failure by the test suite. This reverts commit f9a54be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should look at the actual error and fix it. There are some hard coded wait times in the tests, if they're causing the failure we can increase them somewhat. AFAICT candidates functions to adjust are
withSeleniumServerandwithRetry.Running the
gctest withcpulimit -l 1results in:which may also be considered a failure by the test suite.
This reverts commit f9a54be.