Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Group, with the intention that the groups library is used instead #24

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/develop' into no-group
Ericson2314 committed Jun 23, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 512a1bb6994437345b416e286849e56b423e4d6d
22 changes: 20 additions & 2 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -9,8 +9,26 @@
orphan for backwards compat, temporarily, but it should eventually be removed
everywhere.

* `Additive` is still defined, because the `Abelian` from `groups` has too
stringent a constraint.
## Unreleased

* Use `commutative-semigroups` for `Commutative`, making `Additive` a
deprecated alias.

## 0.0.6.0 - 2022-06-10

* Add `PatchOrReplacement`, patch which either is some other patch type or a
new replacement value.

* Support GHC 9.2

## 0.0.5.2 - 2022-01-09

* Correct field order of `PatchMapWithMove.NodeInfo`.

When we this was reimplemented as a pattern synonym wrapper in 0.0.5.0, we
accidentally flipped the argument order. Reversing it now to match 0.0.4.0
and restore compatibility. The previous releases in the 0.0.5.\* series will
correspondingly be deprecated.

## 0.0.5.1 - 2021-12-28

4 changes: 2 additions & 2 deletions dep/reflex-platform/github.json
Original file line number Diff line number Diff line change
@@ -3,6 +3,6 @@
"repo": "reflex-platform",
"branch": "develop",
"private": false,
"rev": "efc6d923c633207d18bd4d8cae3e20110a377864",
"sha256": "121rmnkx8nwiy96ipfyyv6vrgysv0zpr2br46y70zf4d0y1h1lz5"
"rev": "ac66356c8839d1dc16cc60887c2db5988a60e6c4",
"sha256": "0zk8pf72lid6cqq4mlr1mcwh6zd5lz9i83kw519aci6mfba1afvq"
}
2 changes: 1 addition & 1 deletion patch.cabal
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ library

if flag(split-these)
build-depends: these >= 1 && <1.2
, semialign >=1 && <1.2
, semialign >=1 && <1.3
else
build-depends: these >= 0.4 && <0.9

2 changes: 1 addition & 1 deletion src/Data/Patch.hs
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ import Data.Patch.MapWithMove as X
, unsafePatchMapWithMove
)

-- | The elements of an 'Additive' 'Semigroup' can be considered as patches of their own type.
-- | The elements of an 'Commutative' 'Semigroup' can be considered as patches of their own type.
newtype AdditivePatch p = AdditivePatch { unAdditivePatch :: p }

instance Commutative p => Patch (AdditivePatch p) where
You are viewing a condensed version of this merge commit. You can view the full changes here.