-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add onSiderCollapsed to RefineThemedLayoutV2Props #6527
feat: add onSiderCollapsed to RefineThemedLayoutV2Props #6527
Conversation
🦋 Changeset detectedLatest commit: 1f0be4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
94020bf
to
b3d23bc
Compare
refine
|
Project |
refine
|
Branch Review |
releases/december-2024
|
Run status |
|
Run duration | 13m 31s |
Commit |
|
Committer | Alican Erdurmaz |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
7
|
|
0
|
|
156
|
View all changes introduced in this branch ↗︎ |
Hello @OmkarBansod02 thanks for improving Refine, everything looks great! If you have time, can you add documentation for these changes? After that, I believe this PR will be ready for release. |
Yeah sure ! @alicanerdurmaz Can you please give me some hints Or any reference point to start from. |
…m/OmkarBansod02/refine into feat/add-onSiderCollapsed-handler
Hey @alicanerdurmaz , I've added documentation for the
Could you please review this and let me know if it aligns with the expected style and content? so i can move forward with other UI docs . |
1d26133
into
refinedev:releases/december-2024
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The current behavior is that the collapsed state of the sider is not persisted out of the box. Developers need to write additional code to manage and persist the collapsed state, which adds extra effort for implementing this common UX feature.
What is the new behavior?
The sider now supports out-of-the-box persistence of the collapsed state through the new onSiderCollapsed boolean option. This enhancement eliminates the need for additional code to manage and persist the collapsed state, improving the developer experience and enhancing UX.
fixes #6508
Notes for reviewers
I’ve added the
onSiderCollapsed
feature to make it easier to persist the sider's collapsed state. I haven’t written tests for it yet but can definitely add them if needed. just let me know .