fix: React-Native package exports #4887

aryaemami59 · 2025-03-11T16:28:36Z

This PR:

Resolves Warning with @reduxjs/toolkit/query/react Is this an Expo or RTK issue? #4524.

codesandbox · 2025-03-11T16:28:40Z

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

codesandbox-ci · 2025-03-11T16:31:01Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

netlify · 2025-03-11T16:34:06Z

✅ Deploy Preview for redux-starter-kit-docs ready!

Name	Link
🔨 Latest commit	`17fed4b`
🔍 Latest deploy log	https://app.netlify.com/sites/redux-starter-kit-docs/deploys/68191e4cd9cf7b00082fc287
😎 Deploy Preview	https://deploy-preview-4887--redux-starter-kit-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

markerikson · 2025-03-12T22:10:39Z

@aryaemami59 can you summarize the package changes and why they improve things?

BenQoder · 2025-05-02T19:11:10Z

This fix is essential, Because in the latest version of Expo (Expo 53); It logs this warning uncountable times.

I hope it is reviewed and merged soon

phryneas

Not sure about the tsup changes (was this just a port to TS or bigger changes?) but the exports field changes generally seem reasonable. This should at least be a minor bump, though.

packages/toolkit/package.json

phryneas · 2025-05-03T14:00:26Z

packages/toolkit/query/package.json

  "types": "./../dist/query/index.d.ts",
-  "exports": {


Dropping the exports field should be okay - a bundler that supports exports should look at the root-level package.json.

phryneas · 2025-05-03T14:01:37Z

packages/toolkit/query/package.json

@@ -4,16 +4,9 @@
  "description": "",
  "type": "module",
  "module": "../dist/query/rtk-query.legacy-esm.js",
-  "main": "../dist/query/cjs/index.js",
+  "main": "./../dist/query/rtk-query.modern.mjs",


Here be dragons - this switches from CJS to ESM. Probably be fine, since only outdated bundlers would look at this file at all, but pointing it out.

Without this vitest will fail unless we explicitly specify resolve.mainFields in vitest config files. Still not entirely sure why this happens, I know it's vite related and with this change added everything seems to work okay.

On the flip side, this was here to keep Webpack 4 working.

Obviously at this point we shouldn't want to care about Webpack 4 much, but that's why it's here.

Why is Vitest looking at this field at all anyway? Shouldn't it be following exports instead and not even looking at this file?

examples/publish-ci/node-esm/package.json

examples/publish-ci/node-standard/package.json

markerikson · 2025-03-30T20:09:38Z

packages/toolkit/query/package.json

@@ -4,16 +4,9 @@
  "description": "",
  "type": "module",
  "module": "../dist/query/rtk-query.legacy-esm.js",
-  "main": "../dist/query/cjs/index.js",
+  "main": "./../dist/query/rtk-query.modern.mjs",


❓ Why did this change? main should point to a CJS file as far as I know.

packages/toolkit/tsup.config.mts

markerikson · 2025-05-04T00:10:52Z

packages/toolkit/query/package.json

@@ -4,16 +4,9 @@
  "description": "",
  "type": "module",
  "module": "../dist/query/rtk-query.legacy-esm.js",
-  "main": "../dist/query/cjs/index.js",
+  "main": "./../dist/query/rtk-query.modern.mjs",


On the flip side, this was here to keep Webpack 4 working.

Obviously at this point we shouldn't want to care about Webpack 4 much, but that's why it's here.

Why is Vitest looking at this field at all anyway? Shouldn't it be following exports instead and not even looking at this file?

accidental

- This is done to avoid the `module-sync` condition.

markerikson · 2025-05-04T20:53:54Z

Spent a couple hours poking at this and concluded that Vitest does not seem to be looking at exports for those nested entry points :(

I honestly still don't know why. This is the closest I could find:

How vitest resolves dependency exports vitest-dev/vitest#4233

but that just says "it uses the Node resolution algorithm", which ought to still involve exports I'd think.

As a result, we were seeing a module mismatch - it was importing redux-toolkit.modern.mjs, but rtk-query.development.cjs, and thus Bad Things happened.

What we've ended up on is specifying resolve: {mainFields: ["module"]}, which forces it to stop looking at the main field and land on module, which currently points to our legacy-esm.js artifacts. That's not good and will almost definitely bite us at some point, but it lets the "test against dist" test pass for now.

markerikson · 2025-05-05T20:39:37Z

Further updates:

After some discussion on Bluesky, I wondered if this was specific to either Yarn or NPM in general, due to package.json also having the name: "@reduxjs/toolkit" value, and thus maybe preventing Vitest from going into node_modules to find the installed version.

After further ~~random flailing and changing settings~~ investigation, I concluded that this is indeed the case. So, instead of adding a TEST_DIST-specific alias, what we really need is to temporarily alter the package name field so that Vitest is forced to look inside of node_modules instead. Did that in the tests.yml workflow.

I've confirmed (locally at least) that this does indeed result in Vitest loading the rtk-query.modern.mjs artifact as we would want.

aryaemami59 self-assigned this Mar 11, 2025

This was referenced Mar 11, 2025

chore: update React-Native example app #4888

Merged

chore: update Expo example app #4889

Merged

aryaemami59 force-pushed the fix/react-native-package-exports branch from 49c76b3 to 2cecb47 Compare March 11, 2025 16:39

aryaemami59 marked this pull request as ready for review March 11, 2025 17:06

aryaemami59 mentioned this pull request Mar 11, 2025

Warning with @reduxjs/toolkit/query/react Is this an Expo or RTK issue? #4524

Open

aryaemami59 force-pushed the fix/react-native-package-exports branch from 2cecb47 to 25f7b50 Compare March 16, 2025 11:06

aryaemami59 force-pushed the fix/react-native-package-exports branch from 25f7b50 to c67da92 Compare March 31, 2025 18:22

aryaemami59 force-pushed the fix/react-native-package-exports branch from c67da92 to 2ebf48c Compare April 11, 2025 10:07

aryaemami59 force-pushed the fix/react-native-package-exports branch from 2ebf48c to c944724 Compare April 27, 2025 12:18

aryaemami59 mentioned this pull request May 1, 2025

Error message indicates that the "exports" field in the package.json #4960

Open

aryaemami59 force-pushed the fix/react-native-package-exports branch 2 times, most recently from 9de562c to f9f283d Compare May 1, 2025 15:36

phryneas reviewed May 3, 2025

View reviewed changes

aryaemami59 force-pushed the fix/react-native-package-exports branch from f9f283d to e4b5479 Compare May 3, 2025 23:47

aryaemami59 commented May 3, 2025

View reviewed changes

examples/publish-ci/node-esm/package.json Show resolved Hide resolved

aryaemami59 commented May 3, 2025

View reviewed changes

examples/publish-ci/node-standard/package.json Show resolved Hide resolved

markerikson previously approved these changes May 4, 2025

View reviewed changes

aryaemami59 added 6 commits May 4, 2025 12:44

Rename tsup.config.ts to tsup.config.mts

848e285

Fix tsup config

4976130

Fix exports field in package.json

d95a9a3

Fix nested package.json files

a2194de

Fix fixUniqueSymbolExports.mts

2ba1e91

Explicitly disable --experimental-require-module

2c10c81

- This is done to avoid the `module-sync` condition.

Bump tsup

595db02

aryaemami59 force-pushed the fix/react-native-package-exports branch from e4b5479 to 595db02 Compare May 4, 2025 17:45

Revert nested package main changes and fix "dist test" config

37ca279

aryaemami59 linked an issue May 4, 2025 that may be closed by this pull request

Error message indicates that the "exports" field in the package.json #4960

Open

markerikson force-pushed the fix/react-native-package-exports branch from d96d5cd to 7c1eacc Compare May 5, 2025 20:19

Maybe really fix dist tests

17fed4b

markerikson force-pushed the fix/react-native-package-exports branch from 7c1eacc to 17fed4b Compare May 5, 2025 20:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: React-Native package exports #4887

fix: React-Native package exports #4887

aryaemami59 commented Mar 11, 2025

codesandbox bot commented Mar 11, 2025

codesandbox-ci bot commented Mar 11, 2025 •

edited

Loading

netlify bot commented Mar 11, 2025 •

edited

Loading

markerikson commented Mar 12, 2025

BenQoder commented May 2, 2025 •

edited

Loading

phryneas left a comment

phryneas May 3, 2025

phryneas May 3, 2025

aryaemami59 May 4, 2025

markerikson May 4, 2025

markerikson Mar 30, 2025

markerikson May 4, 2025

markerikson commented May 4, 2025

markerikson commented May 5, 2025

fix: React-Native package exports #4887

Are you sure you want to change the base?

fix: React-Native package exports #4887

Conversation

aryaemami59 commented Mar 11, 2025

This PR:

codesandbox bot commented Mar 11, 2025

Review or Edit in CodeSandbox

codesandbox-ci bot commented Mar 11, 2025 • edited Loading

netlify bot commented Mar 11, 2025 • edited Loading

✅ Deploy Preview for redux-starter-kit-docs ready!

markerikson commented Mar 12, 2025

BenQoder commented May 2, 2025 • edited Loading

phryneas left a comment

Choose a reason for hiding this comment

phryneas May 3, 2025

Choose a reason for hiding this comment

phryneas May 3, 2025

Choose a reason for hiding this comment

aryaemami59 May 4, 2025

Choose a reason for hiding this comment

markerikson May 4, 2025

Choose a reason for hiding this comment

markerikson Mar 30, 2025

Choose a reason for hiding this comment

markerikson May 4, 2025

Choose a reason for hiding this comment

markerikson commented May 4, 2025

markerikson commented May 5, 2025

codesandbox-ci bot commented Mar 11, 2025 •

edited

Loading

netlify bot commented Mar 11, 2025 •

edited

Loading

BenQoder commented May 2, 2025 •

edited

Loading