Skip to content

Feature/add type parameter for id in create entity adapter #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Matt-Ord
Copy link
Contributor

Closes #2098
Re making the pr #2099 after was closed

@codesandbox
Copy link

codesandbox bot commented Nov 12, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@Matt-Ord
Copy link
Contributor Author

What is the timeline for rtk 2.0? I'm happy to rebase/ re work this when it comes close to the next release.

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit bfb9883
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/636f6d514a82b900096c98cd
😎 Deploy Preview https://deploy-preview-2901--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson markerikson added this to the 2.0 milestone Jan 28, 2023
@markerikson markerikson changed the base branch from master to v2.0-integration January 28, 2023 19:11
@markerikson
Copy link
Collaborator

@Matt-Ord : we're actively working on RTK 2.0 now! I've re-pointed this at our v2.0-integration branch. Please feel free to update this as needed!

@Matt-Ord
Copy link
Contributor Author

Sorry for being slow to respond- I might have time to look at this at the weekend.
Do you think it would be better to have Id as the first type parameter (to mirror the type of Record) for types such as entity state?
Also similarly for createEntityAdapter

@markerikson
Copy link
Collaborator

@Matt-Ord Hmm. No, the most important thing is the type of the data. The ID thing still feels secondary to me.

@EskiMojo14
Copy link
Collaborator

closing in favour of #3187, now that's merged in :)

@EskiMojo14 EskiMojo14 closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type parameter for Id in createEntityAdapter
3 participants