-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
split enhanceEndpoints
into addTagTypes
and enhanceEndpoint
#2730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Unfortunately adding a function that can change existing types pretty much ruins all internal types :/ |
This looks awesome, thanks! ❤️ I will test it when I have a spare time. |
@phryneas I'm sorry that it took me so long, had a pretty rough month. I've been trying to install the PR version in my project from the
But it behaves buggy, for example after mutation it leaves the query in constant Is there a way to easily install P.S. I also tried to install with defined commit id, but it failed. Probably because |
Huh, for some reason there doesn't seem a CodeSandbox build for this one. @bogdan0083 I'm sorry about this, but this change has a lot of consequences for the internals, so we can't get that into the upcoming 1.9 release and I have stashed it for the moment being. I'll hopefully be able to come around it once 1.9 is out the door and everything has settled down. Until then it probably doesn't make sense testing it. But please, give me a ping to remind me of this a few weeks after the 1.9 release :) |
Sure! No worries, I’ll ping you after a while 🙂 |
@phryneas Hey there! Pinging to remind you of this feature :) |
This would deprecate
enhanceEndpoints
and add new methodsaddTagTypes
andenhanceEndpoint
.These are easier to type from our side and would allow the argument and return type of existing endpoints to be changed.