159 bug download and share preview functionality don't pass full query to backend #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where download and share preview functionality didn't pass the full query context to the backend. Previously, these operations would only use the individual record's timestamp, but now they correctly include the full query range and options (including the when condition) that were used to fetch the records.
Changes:
- Added query context tracking to maintain the range and options used for fetching records
- Updated download, share, and preview functionality to pass full query parameters to
createQueryLink - Improved type safety by adding proper interfaces for table rows and indexed records
- Enhanced ShareLinkModal with better state management and clipboard detection
- Improved RecordPreview with better size handling and auto-preview logic
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Views/BucketPanel/types.ts | New type definition for records with table index |
| src/Views/BucketPanel/EntryDetail.tsx | Core fix: tracks query context and passes it to download/share/preview operations |
| src/Views/BucketPanel/EntryDetail.test.tsx | Updated test expectations to verify full query context is passed |
| src/Views/BucketPanel/EntryDetail.css | Removed obsolete CSS rule for CodeMirror height |
| src/Components/ShareLinkModal.tsx | Added proper typing and improved state management for record handling |
| src/Components/ShareLinkModal.test.tsx | Updated test to use proper types |
| src/Components/RecordPreview/RecordPreview.tsx | Added query context parameters to support the backend fix |
| src/Components/RecordPreview/RecordPreview.test.tsx | Updated test expectation for improved error message |
| src/Components/JsonEditor/JsonQueryEditor.tsx | Improved validation status display logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
atimin
reviewed
Jan 22, 2026
Member
atimin
left a comment
atimin
left a comment
There was a problem hiding this comment.
Perfect, but I found few new bugs. I'll create new issues.
atimin
deleted the
159-bug-downloadshare-preview-functionality-doesnt-pass-full-query-to-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
Include full query options when generating download/share/preview links
Related issues
No
Does this PR introduce a breaking change?
No
Other information: