Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iceberg/table_io: support azure protocol scheme #24081

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Nov 8, 2024

Azure Blob Storage uses abs:// as a protocol scheme. For Iceberg metadata locations to work they have to include the correct uri.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

Azure Blob Storage uses `abs://` as a protocol scheme. For Iceberg
metadata locations to work they have to include the correct uri.

Signed-off-by: Michał Maślanka <[email protected]>
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should do the same in manifest_io?

@andrwng
Copy link
Contributor

andrwng commented Nov 8, 2024

Actually maybe we should put to_uri into metadata_io

@vbotbuildovich
Copy link
Collaborator

@mmaslankaprv mmaslankaprv merged commit c165f59 into redpanda-data:dev Nov 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants