cluster: Sanction redpanda.leaders.preference on invalid license - create topic #24074
+33
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
previously approved these changes
Nov 8, 2024
pgellert
previously approved these changes
Nov 8, 2024
7 tasks
IoannisRP
force-pushed
the
ik-sanction-pin-leadership-create-topic
branch
from
0cbf432
to
498f397
Compare
|
- Extend test to allow properties of any type.
IoannisRP
force-pushed
the
ik-sanction-pin-leadership-create-topic
branch
from
498f397
to
c5cb776
Compare
|
|
@ztlpn would appreciate your look here as well, thank you! |
michael-redpanda
previously approved these changes
Nov 11, 2024
BenPope
reviewed
Nov 11, 2024
BenPope
previously approved these changes
Nov 11, 2024
IoannisRP
dismissed stale reviews from BenPope and michael-redpanda
via
e78e7d1
IoannisRP
force-pushed
the
ik-sanction-pin-leadership-create-topic
branch
from
c5cb776
to
e78e7d1
Compare
Implements CORE-8042 - Sanction-22 If there is no valid license, request to create a topic with redpanda.leaders.preference enabled will be rejected.
IoannisRP
force-pushed
the
ik-sanction-pin-leadership-create-topic
branch
from
e78e7d1
to
1ddda34
Compare
|
Addressed #24074 (comment) and #24074 (comment) |
BenPope
approved these changes
Nov 11, 2024
pgellert
approved these changes
Nov 11, 2024
michael-redpanda
approved these changes
Nov 11, 2024
oleiman
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: CORE-8042 - Sanction 22
Implement sanction(s) on leadership pinning properties when there is no valid license:
redpanda.leaders.preferencevalue will be denied.Backports Required
Release Notes