Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] gha/labeler: fix format of yml file for v5 #19630

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Jun 11, 2024

Backport of PR #19625

fixes error in Pull Request Labeler / triage (pull_request_target) check:

Error: found unexpected type for label 'area/k8s' (should be array of config options)

resolved conflict by only transforming what was already in v23.2.x branch

jira: https://redpandadata.atlassian.net/browse/PESDLC-1510

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

The v5 of labeler has breaking change that needs update to the
configuration file:
https://github.com/actions/labeler/tree/v5.0.0?tab=readme-ov-file#breaking-changes-in-v5

This fixes it and retains existing behavior. Just syntax differences.

(cherry picked from commit d2e7e86)

Conflicts:
	.github/labeler.yml

resolved conflict by only transforming what was already in v23.2.x
branch
@andrewhsu andrewhsu requested a review from a team as a code owner June 11, 2024 17:59
@andrewhsu andrewhsu requested review from savex and removed request for a team June 11, 2024 17:59
@andrewhsu
Copy link
Member Author

will need force merging because of same reason as original PR

@andrewhsu
Copy link
Member Author

force merging because of stated reason

@andrewhsu andrewhsu merged commit d7b2baf into v23.2.x Jun 12, 2024
35 of 36 checks passed
@andrewhsu andrewhsu deleted the PESDLC-1510-v23.2.x-fix-labeler-format branch June 12, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants